- User Since
- Nov 1 2013, 2:32 AM (194 w, 2 d)
Jun 20 2017
Retrying the diff... (man I hate arcanist)
Jun 19 2017
Rebased per @kparal 's comments.
Jun 12 2017
- Update yumrepo.conf location per diff comments and remove yumrepo.conf
May 22 2017
May 19 2017
May 18 2017
Sorry for the spam. Last arc diff went against master I think, since I forgot to base it off the right commit - so it was showing a ton of stuff not included in this review.
Updated diff to reflect comments in review.
- Updated to reflect review comments.
May 17 2017
May 16 2017
We can probably add some logic to manipulate the version of Fedora that goes into the container we run. I'll look into it.
May 15 2017
May 4 2017
Apr 24 2017
'compose' is in the canonical list of accepted types: https://pagure.io/taskotron/libtaskotron/blob/develop/f/libtaskotron/check.py#_244
Apr 23 2017
FWIW, it's pure JS - not jquery. So it'll work in all browsers .
Apr 20 2017
I saw this issue as a js issue, and I fixed it as such. It could be done with a url_for(). But this way it's one line in a template which has minimal chance of impacting anything else and is easy to revert.
Apr 19 2017
Mar 16 2017
I'm updating the tasks to throw an exception if it can't get the image.
I'd put this response in the task that was being called - as I thought it fit what "NEEDS_INSPECTION" was supposed to be. I've updated the task to report "FAILED" in these instances, so we'll see a failure in this case. Closing this issue.
Mar 14 2017
Mar 13 2017
So it looks to me like it actually did what it's supposed to do: reported NEEDS_INSPECTION. It failed to grab the image because the value for the Cloud Base image was wrong, and ansible couldn't reach the VM. I'll fix it and submit a patch.
Mar 9 2017
Mar 8 2017
There, I used arcanist. I have a container for it now if anyone wants it.
Updated the diff using arcanist. Below are all the commits included in the past of this revision.
Mar 7 2017
Don't call do_trigger in the process() method.
@mkrizek I think I got everything, let me know if I missed something.
Fixed multiple issues @mkrizek brought up.
Mar 3 2017
@kparal I created this diff manually through the web interface.
I forgot to update the strings to turn on the consumer in my trigger as well as in fedmsg.d/taskotron-trigger.py. The most recent diff includes those changes.
Mar 2 2017
Combined the two into a single view. Thought it would display in addition to, not in place of.
Fixed the issue I mentioned before.
One thing in this is wrong - that's the repo to pull the task from for the CloudCompose. I'll update that here as soon as I create the task for it to pull, right now it's just pointed at an ansible repo.
Nov 5 2015
Nov 4 2015
- fix: make domain xml more generic
- fix: no longer crash when destroying unregistered domain
Nov 3 2015
- fix: use generic CPU in template and cleaned up comments
Nov 2 2015
So, it seems I had already updated to this revision and phab doesn't check for duplicates? I obviously did something wrong - not sure what it is though. Sorry for the spam.
feature: use jinja instead of munging xml directly
Oct 20 2015
Awesome, I'll make the changes to docs and the template default and push it out.
Oct 15 2015
Oct 14 2015
Note, I still need to better generalize the template a bit - make sure everything there is workable for any libvirt host.
- fix: use jinja instead of xml for setting up the domain template
Oct 9 2015
- fix: remove virsh calls and replace with libvirt calls
Oct 8 2015
Oct 7 2015
Sep 28 2015
Seems sane to me.
Sep 25 2015
Sep 24 2015
You mean the warning or the 'state?'
Sep 23 2015
Done and in the dev branch.
Merged to dev.
This seems to work out of the box, as evidenced by the Atomic test day. Closing since there doesn't seem to be anything we need to do for it.