jskladan (Josef Skládanka)Administrator
User

Projects (6)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Nov 7 2013, 8:47 AM (202 w, 4 d)
Roles
Administrator
Availability
Available

Recent Activity

Aug 7 2017

jskladan added a comment to D1083: fedorabase.pm to support new OFW for POWERPC.

@jskladan we already did that; see above comments.

Aug 7 2017, 6:39 PM
jskladan edited the content of 20170807-fedoraqadevel.
Aug 7 2017, 2:07 PM
jskladan abandoned D1196: *WIP* More hacky support, but for containers.

moved here: https://pagure.io/taskotron/libtaskotron/pull-request/388

Aug 7 2017, 12:01 PM · libtaskotron
jskladan commandeered D1196: *WIP* More hacky support, but for containers.

commandeering to abandon

Aug 7 2017, 12:01 PM · libtaskotron
jskladan abandoned D966: Taskotron init script PoC.

Moved to https://pagure.io/taskotron/libtaskotron/pull-request/387

Aug 7 2017, 11:58 AM · libtaskotron
jskladan commandeered D966: Taskotron init script PoC.

Commandeering to close

Aug 7 2017, 11:57 AM · libtaskotron
jskladan abandoned D1150: Decouple ExecDB from Buildbot.

moved to https://pagure.io/taskotron/execdb/pull-request/13

Aug 7 2017, 11:54 AM
jskladan added a comment to D1083: fedorabase.pm to support new OFW for POWERPC.

Guys, note that we just officially stopped using Phabricator. It is not being powered off right now, but I suggest moving the diff, and conversation to an appropriate pagure repo as a PR https://pagure.io/fedora-qa/os-autoinst-distri-fedora. Note that the discussion is archieved here: https://fedorapeople.org/groups/qa/phabarchive/differentials/phab.qa.fedoraproject.org/D1083.html

Aug 7 2017, 11:50 AM
jskladan added a comment to D1206: Add Dockerfile and OpenShift template.

Hey, guys, just a note here - we just officially seized using Phabricator. This does not necessarily change much for you - we are not powering it off right now, but we stopped tracking it. If you come to the final version of the diff, please create a PR against ResultsDB at Pagure https://pagure.io/taskotron/resultsdb, also note, that the contents of the debate/last diff is archived here https://fedorapeople.org/groups/qa/phabarchive/differentials/phab.qa.fedoraproject.org/D1206.html, if you wanted to reference it in the future.
Best, your friendly FedoraQA!

Aug 7 2017, 11:48 AM
jskladan added a comment to D1205: correct the example settings for the stomp plugin in settings.py.example.

Merged to resultsdb. This seemed fine, but if it does not, let me know @ralph

Aug 7 2017, 11:43 AM
jskladan added a comment to D1209: ship Alembic migration scripts as package data.

Merged, thanks! Hopefully phab will reflect this shortly.

Aug 7 2017, 11:42 AM
jskladan added a comment to D1187: Update template to work regardless of what base url execdb has..

This was, in the end, not fine, but I based a fix on this, which will, hopefully close this diff shortly.

Aug 7 2017, 11:39 AM
jskladan edited the content of 20170807-fedoraqadevel.
Aug 7 2017, 6:24 AM
jskladan edited the content of 20170807-fedoraqadevel.
Aug 7 2017, 6:24 AM

Aug 1 2017

jskladan removed a project from T733: Move openQA job scheduling to taskotron: taskotron-trigger.
Aug 1 2017, 4:15 PM · fedora_openqa
jskladan closed T6: investigate the use of a graph backend for resultsdb as "Wontfix".
Aug 1 2017, 4:11 PM · resultsdb
jskladan edited projects for T893: resultsdb_frontend: populate the search box with current search values, added: Unknown Object (Project); removed resultsdb.
Aug 1 2017, 4:11 PM · Unknown Object (Project), papercuts
jskladan closed T893: resultsdb_frontend: populate the search box with current search values as "Resolved".
Aug 1 2017, 4:11 PM · Unknown Object (Project), papercuts
jskladan edited projects for T10: redesign resultsdb frontend, added: Unknown Object (Project); removed resultsdb.
Aug 1 2017, 4:09 PM · Unknown Object (Project)
jskladan closed T10: redesign resultsdb frontend as "Wontfix".
Aug 1 2017, 4:09 PM · Unknown Object (Project)
jskladan edited projects for T582: clarify that a timestamp is in UTC on details page, added: Unknown Object (Project); removed resultsdb.
Aug 1 2017, 4:08 PM · Unknown Object (Project), papercuts
jskladan edited projects for T907: Make resultsdb_api Python 3 compatible, added: Unknown Object (Project); removed resultsdb.
Aug 1 2017, 4:08 PM · Unknown Object (Project)
jskladan renamed T937: Frontend crashes when /latest endpoint is used from "resultsdb_frontend crashes when /latest endpoint is used" to "Frontend crashes when /latest endpoint is used".
Aug 1 2017, 4:08 PM · Unknown Object (Project)
jskladan closed T794: change Summary to Note, change rendering a bit as "Resolved".
Aug 1 2017, 4:06 PM · Restricted Project, papercuts, resultsdb
jskladan edited projects for T795: test cases in search field are hardcoded and outdated, added: Unknown Object (Project); removed resultsdb.
Aug 1 2017, 4:05 PM · Unknown Object (Project)
jskladan closed T795: test cases in search field are hardcoded and outdated as "Resolved".
Aug 1 2017, 4:04 PM · Unknown Object (Project)
jskladan renamed T861: Limit searches by time by default from "resultsdb_frontend: limit searches by time by default" to "Limit searches by time by default".
Aug 1 2017, 4:04 PM · Unknown Object (Project), papercuts
jskladan renamed T889: search completion doesn't work from "resultsdb_frontend: search completion doesn't work" to "search completion doesn't work".
Aug 1 2017, 4:03 PM · Unknown Object (Project), papercuts
jskladan renamed T900: test suite is failing from "resultsdb_api: test suite is failing" to "test suite is failing".
Aug 1 2017, 4:03 PM · Unknown Object (Project)
jskladan edited projects for T900: test suite is failing, added: Unknown Object (Project); removed resultsdb.
Aug 1 2017, 4:03 PM · Unknown Object (Project)
jskladan archived repos-taskotron.
Aug 1 2017, 4:00 PM
jskladan archived pytap13.
Aug 1 2017, 3:59 PM
jskladan archived package-checks.
Aug 1 2017, 3:58 PM
jskladan edited projects for T12: Create comprehensive functional tests for package level checks, added: new-check-ideas; removed package-checks.
Aug 1 2017, 3:58 PM · new-check-ideas
jskladan edited projects for T367: New Check: run fedora-review on all incoming new package builds, added: new-check-ideas; removed package-checks.
Aug 1 2017, 3:58 PM · new-check-ideas
jskladan removed a project from T765: Make dist-git repos handling more efficient in trigger/buildbot: taskotron-trigger.
Aug 1 2017, 3:57 PM · Restricted Project, infrastructure
jskladan removed a project from T902: Report test priority to ResultsDB for now: os-autoinst-distri-fedora.
Aug 1 2017, 3:55 PM · fedora_openqa
jskladan removed a project from T938: Duplicate custom partitioning tests for blivet-gui: fedora_openqa.
Aug 1 2017, 3:54 PM · os-autoinst-distri-fedora
jskladan edited projects for T908: Allow for Jenkins to be used in the Taskotron stack, added: Restricted Project; removed infrastructure.
Aug 1 2017, 1:11 PM · Restricted Project
jskladan closed T908: Allow for Jenkins to be used in the Taskotron stack as "Resolved".

As we discussed lately, it is wise to try replacing buildbot with Jenkins - not only is it a pleasing decision, but it might be practical, as we might start using somebody else's infrastructure (CentosCI comes to mind), and get rid of some of the sysadmining.

Aug 1 2017, 1:10 PM · Restricted Project

Jul 27 2017

jskladan closed T584: make use of the taskotron logo as "Resolved".

Already used on Taskotron landing page(s) for quite a time

Jul 27 2017, 1:59 PM · papercuts, infrastructure, execdb, baseweb, resultsdb

Jul 26 2017

jskladan removed a revision from T511: implement search for execdb: D1208: master.cfg for Buildbot and new ExecDB.
Jul 26 2017, 12:06 PM · execdb
jskladan removed a task from D1208: master.cfg for Buildbot and new ExecDB: T511: implement search for execdb.
Jul 26 2017, 12:06 PM · infrastructure
jskladan removed a revision from T511: implement search for execdb: D1150: Decouple ExecDB from Buildbot.
Jul 26 2017, 10:26 AM · execdb
jskladan removed a task from D1150: Decouple ExecDB from Buildbot: T511: implement search for execdb.
Jul 26 2017, 10:26 AM
jskladan added a revision to T511: implement search for execdb: D1208: master.cfg for Buildbot and new ExecDB.
Jul 26 2017, 10:22 AM · execdb
jskladan added a task to D1208: master.cfg for Buildbot and new ExecDB: T511: implement search for execdb.
Jul 26 2017, 10:22 AM · infrastructure
jskladan added a revision to T511: implement search for execdb: D1150: Decouple ExecDB from Buildbot.
Jul 26 2017, 10:11 AM · execdb
jskladan added a task to D1150: Decouple ExecDB from Buildbot: T511: implement search for execdb.
Jul 26 2017, 10:11 AM
jskladan removed a revision from T511: implement search for execdb: D1150: Decouple ExecDB from Buildbot.
Jul 26 2017, 10:10 AM · execdb
jskladan removed a task from D1150: Decouple ExecDB from Buildbot: T511: implement search for execdb.
Jul 26 2017, 10:10 AM
jskladan added a revision to T511: implement search for execdb: D1150: Decouple ExecDB from Buildbot.
Jul 26 2017, 9:58 AM · execdb
jskladan added a task to D1150: Decouple ExecDB from Buildbot: T511: implement search for execdb.
Jul 26 2017, 9:58 AM
jskladan added a comment to T962: F26 is released.
In T962#13929, @kparal wrote:

Josef, can you please deploy the change from D1219 onto taskotron-dev and verify that the config is adjusted properly? Thanks a lot.

Jul 26 2017, 9:51 AM · infrastructure
jskladan added a comment to T962: F26 is released.
Jul 26 2017, 9:49 AM · infrastructure

Jul 17 2017

jskladan edited the content of 20170717-fedoraqadevel.
Jul 17 2017, 1:55 PM

Jul 14 2017

jskladan accepted D1221: remove dnf cache support.

Macro devops: much changes very concerning

Jul 14 2017, 12:54 PM

Jul 12 2017

jskladan accepted D1220: rpm_utils: remove is_installed().
Jul 12 2017, 2:03 PM

Jul 11 2017

jskladan accepted D1219: taskotron-client: replace vars in yumrepoinfo.conf.

This is fine. At least before we have a better solution - I'd go with diff applied on top of the yumrepoinfo downloaded from repos, or installed from package, so we don't even need to keep the local copy, which can get outdated, and still not fail the checks.

Jul 11 2017, 11:38 AM · infrastructure
jskladan added a comment to D1218: add SKIPPED outcome.

Well, I'm not fundamentally absolutely against it, but I'd be happier with you using INFO (which is already present) with "test was skipped" in note - especially if you say that it's supposed to be a pass anyway.
The intended semantics of the result values is
PASSED - everything ok, no questions asked
INFO - the same as PASSED for automation purposes, but a yellow flag for human consumers
NEEDS_INSPECTION - treated as FAILED in automation, red flag for human consumers
FAILED - something really went sideways

Jul 11 2017, 11:26 AM

Jun 30 2017

jskladan added a comment to T960: publish ResultsDB package to PyPI.

for future ref, the reasonable way to get around syncing requirements.txt and setup.py is adding:

+ with open('requirements.txt') as fd:
+     install_requires = [l.strip() for l in fd.readlines() if l.strip() and not l.strip().startswith('#>
...
+       install_requires=install_requires,

to setup.py

Jun 30 2017, 2:33 PM · resultsdb
jskladan lowered the priority of T960: publish ResultsDB package to PyPI from "Low" to "Wishlist".

@mjia BTW what exactly is your use-case, and why is installing from repos not OK for you? I'm asking for two reasons

  1. packaging resultsdb for PyPi is proving to be rather a PITA
  2. if you actually need to use resultsdb, setup is necessary - like creating the database, for example - since you are going to need to solve this too (probably are right now anyway) is installing from repos (aka another line in that script that you'll have to have to setup resultsdb anyway) a problem?
Jun 30 2017, 2:26 PM · resultsdb
jskladan raised the priority of T960: publish ResultsDB package to PyPI from "Wishlist" to "Low".

@mjia, I don't have any fundamental issues with it, apart of the fact that it adds yet another place to store/track deps.

Jun 30 2017, 1:35 PM · resultsdb
jskladan accepted D1217: requirements: limit Flask-RESTful to <= 0.3.5.
Jun 30 2017, 1:05 PM
jskladan accepted D1216: rpm_utils: only support packages in is_installed().
Jun 30 2017, 1:05 PM

Jun 27 2017

jskladan accepted D1214: resultsdb_directive: log submitted results.

lgtm

Jun 27 2017, 3:18 PM
jskladan accepted D1213: Sorting by key plugin for browse results collection.

Looks good. I fixed a non-issue lint error and merged the patch. Thanks!

Jun 27 2017, 8:25 AM

Jun 26 2017

jskladan requested changes to D1213: Sorting by key plugin for browse results collection.

Some minor issues, mostly WRT keeping the new code in the same style as the already existing pieces. My only actual functional issue here is that I'd probably just plain allowed _sort to manipulate submit_time - other fields of the Result object are IMO not really that relevant for custom-sorting, and the "exciting" user data (which I suppose could be more interesting to sort by) is stored in ResultData (and this inaccessible by this patch) anyway.

Jun 26 2017, 2:11 PM

Jun 20 2017

jskladan requested changes to D1196: *WIP* More hacky support, but for containers.

On top of the failing tests, some of which are really weird, I suggest you investigate/fix ASAP, I have some mostly semantical issues.

Jun 20 2017, 3:08 PM · libtaskotron
jskladan accepted D1187: Update template to work regardless of what base url execdb has..

this is fine

Jun 20 2017, 11:31 AM
jskladan added a comment to D1209: ship Alembic migration scripts as package data.

If the rpm builds/installs and migrations keep working, it's fine with me. Have you tried building/installing the package, and running resultsdb [init_alembic, init_db, upgrade_db] commands? I'm not really sure how this works, but it seems like the script_location is a path that needs to work from the location from which the migration is executed. I can see how this works when you run it from inside the repo, but I'm not sure whether this will be the same for the app installed from the package.

Jun 20 2017, 11:30 AM

Jun 19 2017

jskladan accepted D1210: resultsdb_directive: change default log link to artifactsdir.
Jun 19 2017, 12:23 PM

Jun 14 2017

jskladan added a comment to D1206: Add Dockerfile and OpenShift template.

Just fyi - I don't have, and won't have any input, comments on this. Feel free to merge once you decide what you wanna do.

Jun 14 2017, 2:57 PM

Jun 13 2017

jskladan added a comment to D1208: master.cfg for Buildbot and new ExecDB.

will do

Jun 13 2017, 7:49 AM · infrastructure

Jun 12 2017

jskladan added a comment to D1208: master.cfg for Buildbot and new ExecDB.

The patch overrides all the buildsteps we use - since we want every step to report on its progress, we ought to change how they behave, base or not. (I'm not sure I understand what you mean, though).

Jun 12 2017, 2:40 PM · infrastructure
jskladan created D1208: master.cfg for Buildbot and new ExecDB.
Jun 12 2017, 12:46 PM · infrastructure

May 26 2017

jskladan accepted D1191: A stomp messaging plugin..

Who am I to say what works, and what does not :) I guess you tested it with your usecase, so feel free to merge!

May 26 2017, 11:09 AM

May 23 2017

jskladan requested changes to D1196: *WIP* More hacky support, but for containers.

Well, I'm not a huge fan of this - since not all the commands support the --format flag. This will most definitely have the same issues as testcloud does, but if the goal is to really have it now...

May 23 2017, 10:10 AM · libtaskotron
jskladan added a comment to T878: replace depcheck with rpmdeplint.

me likes!

May 23 2017, 9:10 AM · Restricted Project, task-depcheck, Restricted Project, new-check-ideas
jskladan accepted D1195: Support for Ansible Tasks.
  • inner runner :(
May 23 2017, 8:56 AM

May 18 2017

jskladan accepted D1198: change documentation theme.

LG™

May 18 2017, 1:21 PM

May 16 2017

jskladan added a comment to D1196: *WIP* More hacky support, but for containers.

Looks good for a WIP. My concern here is, that with disposable minions, we do a thing where we use "the right fedora version", so e.g. fc24 packages are tested on F24 machine, and so on. I'd like to see the same for Docker - it can even be done quite easily. Not that it needs to happen for PoC, but I'd like at least a big fat "TODO/FIXME" somewhere in the code to remind you of that :)

May 16 2017, 7:19 AM · libtaskotron
jskladan added a reviewer for D1196: *WIP* More hacky support, but for containers: libtaskotron.
May 16 2017, 6:57 AM · libtaskotron
jskladan added a comment to D1195: Support for Ansible Tasks.

Looks good as for a WIP to me. My only real concern here is the broad deletion of all the minion-related code - this might be because I'm not familiar with the design details, but WRT the disposable "minion" - what is the plan for choosing the "right" image for the task (aka using F24 to test F24 packages) that we had in the "previoius" code? Are we dropping the feature alltogether, or is there another process being planned to do that? If so, what is it?

May 16 2017, 6:56 AM

Apr 20 2017

jskladan added a comment to T943: Add basic search functionality to execdb frontend.

What would be the usual search queries?

Apr 20 2017, 2:04 PM · execdb

Apr 3 2017

jskladan added a comment to D1183: changing name of 'branch' parameter so it isn't squashed in buildbot. Fixes T933.

Macro doge: so changes much good very thanks!

Apr 3 2017, 1:47 PM
jskladan accepted D1183: changing name of 'branch' parameter so it isn't squashed in buildbot. Fixes T933.

I'd like to have the task['repo'] changed to task['git_repo'] for the sake of consistency, but it is not a huge issue. Looks good other than this nitpick.

Apr 3 2017, 1:40 PM

Mar 30 2017

jskladan requested changes to D1183: changing name of 'branch' parameter so it isn't squashed in buildbot. Fixes T933.

Apart of the comments below, I'd like to see the testsuite updated to reflect the changes, I don't see how this could pass unittests.

Mar 30 2017, 8:01 AM

Mar 24 2017

jskladan created D1177: Fix default wildcard search in frontend (100x spedup).
Mar 24 2017, 10:15 AM
jskladan accepted D1176: taskformula: replace vars in dictionary keys.

I'd like to see some inline comments, but looks good otherwise

Mar 24 2017, 9:21 AM

Mar 21 2017

jskladan accepted D1171: argparse: change --arch to be a single value instead of a string.

Macro megusta:  me langusta

Mar 21 2017, 1:26 PM
jskladan accepted D1172: yumrepoinfo: specify all primary and alternate arches.
Mar 21 2017, 11:18 AM
jskladan requested changes to D1171: argparse: change --arch to be a single value instead of a string.
Mar 21 2017, 11:17 AM

Mar 14 2017

jskladan accepted D1165: yumrepoinfo: handle alternate arches.
Mar 14 2017, 12:28 PM
jskladan accepted D1164: i386 is now alternate arch since Fedora 26.

Whatevs...

Mar 14 2017, 8:59 AM

Mar 8 2017

jskladan accepted D1160: changing testcase field to 1024.

D1150 will need adjustments, but that's a non issue.

Mar 8 2017, 1:59 PM
jskladan accepted D1159: support multiple builders for tasks stored in distgit. Fixes T925.

Fine with me

Mar 8 2017, 1:58 PM · taskotron-trigger

Mar 3 2017

jskladan retitled D1158: Fix links in job overview from to Fix links in job overview.
Mar 3 2017, 2:49 PM

Feb 23 2017

jskladan retitled D1150: Decouple ExecDB from Buildbot from to Decouple ExecDB from Buildbot.
Feb 23 2017, 12:35 PM
jskladan accepted D1148: docs: add base-design documentation.
Feb 23 2017, 9:02 AM