- User Since
- Jan 6 2017, 8:36 AM (20 w, 17 h)
Mon, May 22
Fri, May 19
Wed, May 17
- correct comment about number of disks in custom btrfs
Tue, May 16
Thu, May 11
Wed, May 10
Tue, May 9
Fri, May 5
Thu, May 4
Fri, Apr 28
Hmm, I don't particularly like having flavors = None for expressing "run on all flavors", but I don't know a better way. Doing flavors = 'all' would mess things up, because string is iterable and also it wouldn't work with schedule.jobs_from_update, so this is OK, I guess.
Thu, Apr 27
Apr 24 2017
Apr 21 2017
- update blivet tests
Apr 20 2017
Apr 18 2017
Hmm, I don't particularly like this (adding new symlink each time we want to run some module more than once?), but it's necessary I guess and it works OK, so until upstream fixes this...
Apr 5 2017
Mar 30 2017
Mar 29 2017
Hmm, for some reason, RC4 jobs still got obsoleted by newest nightly when I've tried it. I'm not sure whether tagging works on my instance, because it doesn't show tags next to group name (as shown here) and also when I filter for "tagged", it doesn't show any group. Only thing that worked for me is setting _NOOBSOLETEBUILD=1 as they mention in their documentation. I should debug why tagging doesn't work for me.
Why this DR doesn't allow me to run arc patch? Anyway, looks correct.
Mar 24 2017
I still don't understand why have they done it. What was the problem with current behaviour?
Mar 22 2017
Mar 21 2017
Mar 9 2017
Code looks OK, but I'm not able to test it, because of obvious reasons :-). Only remaining thing I have found, why did you add new test mediacheck that has MEDIACHECK=1 when none of the tests are using this value? Won't it do just do "default install" test?
I hadn't sent it upstream because their Dockerfiles diverged from ours (looks like they are using it for testing on Travis). I figured out that dockerized openQA on Fedora might be still useful to us from time to time, so I've simplified it as much as possible - removed all those scripts for setting different auth methods (it's meant for testing/development only, so why not use fake auth), got rid of complicated data handling using data volume container and updated it to newest Fedora, created its own repo on Pagure and removed Docker stuff from repo on bitbucket, so I think that we may close this ticket as resolved.
Mar 6 2017
Mar 3 2017
Code looks OK and if we need it right now, feel free to merge it, but I wonder how will the discussion evolve.
Mar 2 2017
Feb 27 2017
See above. I'm not sure whether this is your change or whether this was there from my code, but it needs fixing.
Hmm, code looks OK, but for some reason, trying to run python fedora-openqa.py report --resultsdb "Update-FEDORA-2017-f519ebb3c4" reports only one job from two that were run and are passed into resultsdb.
Feb 24 2017
Code looks OK so far, just say when this stops being "work in progress".
Feb 23 2017
It works without problem.
Feb 22 2017
Feb 14 2017
I had to install py.test from pypi for test to be able to yield. It showed me this warning:
Feb 13 2017
Code looks alright, but I still have to review tests before ACKing.
My reviews for DRs this long are going to be reduced to "Does it work on staging?".
Feb 10 2017
Feb 3 2017
Feb 2 2017
- create results based on TEST_TARGET value
- update to use newest resultsdb_conventions
Feb 1 2017
Update to use resultsdb_conventions.
Validation fails for test called compose.install_usbboot (it contains non-ASCII/dot characters) and I can't remember if we decided that test can be called install_usbboot or not...
I had a few nitpicks, but overall this looks good.