master.cfg for Buildbot and new ExecDB
AcceptedPublic

Authored by jskladan on Jun 12 2017, 12:46 PM.

Details

Reviewers
tflink
mkrizek
Summary

This changes the steps we use so they report their start/stop to Buildbot. There almost certainly is a nicer/better way of doing this like using factory-like code to produce the modified classes, or reimplementing the Bbots push notification code, but given the limited docs, this is the most straight-forward solution

Test Plan

Tested localy with docker setup (which has slightly different master.cfg), so there might be some copy-paste errors. But the overall idea is sound and working.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
jskladan created this revision.Jun 12 2017, 12:46 PM
tflink accepted this revision.Jun 12 2017, 2:05 PM

I'd like to see some more comments to describe what's going on and why we're overriding some pretty base buildsteps but other than that, it looks good to me.

This revision is now accepted and ready to land.Jun 12 2017, 2:05 PM

The patch overrides all the buildsteps we use - since we want every step to report on its progress, we ought to change how they behave, base or not. (I'm not sure I understand what you mean, though).

Overall, the changes are the same for all buildsteps - we override the start and finished methods, to inject the report call into them. The report method just plain HTTP POSTs to an url given to it, and sends the provided data.

All the steps have gained the execdb_url parameter in constructor, in order to store that url (which is constructed partialy in the jinja, and during runtime).

The patch then sets the said execdb_url parameter in every addStep call, so the constructor can be called without exceptions raising.

Does this answer the questions? If not, I'd probably need you to be a bit more specific :)

Yeah, that answers most of the questions - I just wanted them in the master.cfg file for future reference or if someone is looking at it for the first time

mkrizek resigned from this revision.Jul 13 2017, 9:03 AM