README: add testcloud dependency
ClosedPublic

Authored by kparal on Thu, May 18, 1:36 PM.

Details

Summary

We import testcloud in our modules, but it wasn't mentioned in the
README. In turn, even docs building has been failing.

Test Plan

worked in a clean VM after testcloud was installed

Diff Detail

Repository
rLTRN libtaskotron
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kparal created this revision.Thu, May 18, 1:36 PM

testcloud is in PyPI, it should be installed through requirements.txt, no?

kparal planned changes to this revision.Thu, May 18, 2:08 PM

Ah, good catch. The actual problem was with missing libvirt-python. That's a dependency of testcloud, but it clearly doesn't state it on the pypi package. So, we should add the dep to the testcloud package (I'll create a patch). The drawback is that libvirt-python is a bit problematic to install from pypi, it requires to compile some libvirt modules, so it might be actually easier to install it as an rpm anyway. Will look into it.

OK, so, testcloud deps were fixed in D1200 and pushed to pypi.

There's still one problem, though. testcloud depends on libvirt-python. That can be installed from pypi, but requires gcc and libvirt-devel installed, otherwise the installation will fail. So we either need to include libvirt-devel in README, or libvirt-python straight away. Adding libvirt-python seems like the more friendly approach. Adjusting patch.

kparal updated this revision to Diff 3048.Fri, May 19, 1:36 PM
  • add libvirt-python to readme instead, require fixed testcloud from pypi
mkrizek accepted this revision.Mon, May 22, 8:15 AM
This revision is now accepted and ready to land.Mon, May 22, 8:15 AM
Closed by commit rLTRN20940651b087: README: add libvirt-python dependency (authored by Kamil Páral <kparal@redhat.com>). · Explain WhyMon, May 22, 10:59 AM
This revision was automatically updated to reflect the committed changes.